-
-
Notifications
You must be signed in to change notification settings - Fork 33.8k
gh-104683: Rework Argument Clinic error handling #107551
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
erlend-aasland
merged 31 commits into
python:main
from
erlend-aasland:clinic/warn-and-fail
Aug 3, 2023
Merged
Changes from 1 commit
Commits
Show all changes
31 commits
Select commit
Hold shift + click to select a range
36bac55
Rework error handling
erlend-aasland 9cb2ce9
Merge branch 'main' into clinic/warn-and-fail
erlend-aasland 789f5ee
Adapt new test
erlend-aasland 15a246b
Pull in main
erlend-aasland e32d221
Pull in main
erlend-aasland 4350ecc
Align with Alex's changes
erlend-aasland ad5181a
Address review: pass iso. ellipse
erlend-aasland 545e7b6
Address review: add return annotation
erlend-aasland c978a6d
Address review: re.escape
erlend-aasland 33b038c
Address review: fix test
erlend-aasland 7b631a3
Refactor: extract method parse_parameter_name()
erlend-aasland 553cb6e
Address review: re.escape better
erlend-aasland 1514f63
Address review: UserWarning iso. Warning
erlend-aasland d3daef7
Revert "Refactor: extract method parse_parameter_name()"
erlend-aasland aa38570
Pull in main
erlend-aasland 8f3750b
Print debug stuff to stderr
AlexWaygood e8b8d7e
Adapt test
erlend-aasland 79b9859
Print to stdout instead of using warnings.warn
erlend-aasland 57eff9d
Final touches
erlend-aasland 5b8dea9
Pull in main
erlend-aasland 6f5cfae
Fix merge
erlend-aasland 3081729
Try to produce correct line numbers in error messages
erlend-aasland 716bda8
Fixup CLI error formatting
erlend-aasland af79481
Fix reraise of ClinicError in parse()
erlend-aasland d109b63
Adjust tests again
erlend-aasland ecbfe2c
Remove unused import
erlend-aasland 90e1bc9
Mutate the exception
erlend-aasland 7766c3d
Share more code between the `warn()` and `fail()` branches (#49)
AlexWaygood 3d9d6c6
Pull in main
erlend-aasland 8573928
Pull in main
erlend-aasland fcd4721
Add docstring to _expect_failure
erlend-aasland File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev
Previous commit
Add docstring to _expect_failure
- Loading branch information
commit fcd472104ed00e32ff733d45df9ececfacc60632
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.