Skip to content

gh-104306: Fix incorrect comment handling in the netrc module, minor refactor #104511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sleiderr wants to merge 19 commits into
base: main
Choose a base branch
from
Open

gh-104306: Fix incorrect comment handling in the netrc module, minor refactor #104511

Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
52ea05f
Fixed netrc comments handling
sleiderr May 15, 2023
2810677
Implementation that passes all test cases. Rework on the `lexer.get_t…
sleiderr May 15, 2023
68c946d
Removed debug remnants
sleiderr May 15, 2023
dce8305
Merge branch 'main' into gh-104306-netrc-comments
sleiderr May 15, 2023
a542e84
📜🤖 Added by blurb_it.
blurb-it[bot] May 15, 2023
27b83e9
Missing whitespace
sleiderr May 15, 2023
1920abe
Update 2023-05-15-17-22-53.gh-issue-104306.YMiegg.rst
sleiderr May 15, 2023
8c243db
Link to module
sleiderr May 15, 2023
3284bbf
Merge branch 'main' into gh-104306-netrc-comments
sleiderr May 16, 2023
98d0df9
Merge branch 'main' into gh-104306-netrc-comments
sleiderr May 29, 2023
3e1a021
Merge branch 'main' into gh-104306-netrc-comments
sleiderr Mar 13, 2024
47399ef
Merge branch 'main' into gh-104306-netrc-comments
sleiderr Jan 4, 2025
e835819
fix netrc unit tests
sleiderr Jan 6, 2025
7687836
remove extra blank line
sleiderr Jan 6, 2025
7f64f23
remove extra blank line
sleiderr Jan 6, 2025
9e63185
remove extra line
sleiderr Jan 6, 2025
dc72ad1
remove extra blank line
sleiderr Jan 6, 2025
5ed10a7
fix: skip any trailing new line when lexing
sleiderr Jan 7, 2025
e32c360
Merge branch 'main' into gh-104306-netrc-comments
sleiderr Jan 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Link to module 
Co-authored-by: Oleg Iarygin <[email protected]>
  • Loading branch information
@sleiderr @arhadthedev
sleiderr and arhadthedev authored May 15, 2023
commit 8c243db4c359222ad092b5308549c88463af0051
2 changes: 1 addition & 1 deletion Misc/NEWS.d/next/Library/2023-05-15-17-22-53.gh-issue-104306.YMiegg.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
Fix incorrect comment parsing in the ``netrc`` module
Fix incorrect comment parsing in the :mod:`netrc` module.
Copy link
Contributor

@webknjaz webknjaz Jan 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you expand on this and include context that would give an arbitrary changelog reader an idea of how the change might impact them?