Skip to content

GH-101362: Optimise PurePath(PurePath(...)) #101667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
miss-islington merged 8 commits into from
Mar 5, 2023
Merged

GH-101362: Optimise PurePath(PurePath(...)) #101667

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
b01c352
GH-101362: Optimise PurePath(PurePath(...))
barneygale Feb 7, 2023
6db6d55
Tweak PurePath constructor docs to hint that we call `os.fspath()`
barneygale Feb 25, 2023
1b9e2d3
Add tests for bytes paths.
barneygale Feb 28, 2023
bee1ab5
Merge branch 'main' into gh-101362-use-native-pathlib-joining
barneygale Mar 5, 2023
37be083
Apply suggestions from code review
barneygale Mar 5, 2023
782a940
Update Misc/NEWS.d/next/Library/2023-02-07-22-20-32.gh-issue-101362.J…
barneygale Mar 5, 2023
0ecae3d
Use `assertRaisesRegex()` to check TypeError message in test.
barneygale Mar 5, 2023
fbfeedb
Improve TypeError message
barneygale Mar 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Use assertRaisesRegex() to check TypeError message in test.
  • Loading branch information
@barneygale
barneygale committed Mar 5, 2023
commit 0ecae3d57bc60182dece7215ade883aa9bb1cd78
2 changes: 1 addition & 1 deletion Lib/test/test_pathlib.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,7 @@ def test_constructor_common(self):

def test_bytes(self):
P = self.cls
with self.assertRaises(TypeError):
with self.assertRaisesRegex(TypeError, "should be a str object or an os.PathLike object"):
P(b'a')
with self.assertRaises(TypeError):
P(b'a', 'b')
Expand Down