Use subprocess with CREATE_NO_WINDOW flag in ImageShow WindowsViewer#7791
Merged
hugovk merged 1 commit intopython-pillow:mainfrom Mar 11, 2024
Merged
Use subprocess with CREATE_NO_WINDOW flag in ImageShow WindowsViewer#7791hugovk merged 1 commit intopython-pillow:mainfrom
hugovk merged 1 commit intopython-pillow:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #7789
The user has found that calling using ImageShow from within a .pyw file on Windows causes a console to appear, as a result of calling
os.systemfromViewer.Pillow/src/PIL/ImageShow.py
Line 121 in 6782a07
The user has suggested calling subprocess with the CREATE_NO_WINDOW flag to fix this.
https://stackoverflow.com/questions/58943289 / https://stackoverflow.com/a/7006424/4093019 agree with this solution.
Because
subprocess.CREATE_NO_WINDOWonly exists on Windows, I've added a dedicated WindowsViewershow_file()method for this.