This repository was archived by the owner on Jun 22, 2025. It is now read-only.
Add shutdown_delay on the start() function parameter #453
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Change default if time_shutdown is not correct int or float - Accept string if is a digit
Collaborator
|
Hey 👋 Thanks for the PR! I'd like to rename the arg and tweak the error checking to be stricter - can you give me permission to push a commit to your repo/branch please? |
Contributor
Author
|
yes, I've already sent you an invitation. |
b67bf3d to
8e5e90e
Compare
samuelhwilliams
approved these changes
Feb 26, 2021
Collaborator
samuelhwilliams
left a comment
There was a problem hiding this comment.
Thanks for the contribution!
Collaborator
|
@ChrisKnott can't actually merge this but looks like a reasonable PR to add |
fix flake8 warning remplace shortcut `f` not stable on python3.6 by format
Contributor
Author
|
the "f" format shortcut is not stable in version 3.6, |
Collaborator
|
@gaetan1903 Do you still want this merged? |
Contributor
Author
|
I want to merge it with new PR for HacktoberFest, if you can add topic HacktoberFest in this repository @ChrisKnott |
|
What happened to merging this? |
Contributor
Author
|
#529 it's already merge here |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
timer configurable for Eel's shutdown detection mechanism, whereby when any websocket closes, it waits time_shutdown seconds (default 1 second), and then checks if there are now any websocket connections. If not, then Eel closes. In case the user has closed the browser and wants to exit the program.
Try to fix #355 issues: Increase the value shutdown_delay higher to avoid stopping Eel.