This repository was archived by the owner on Jun 22, 2025. It is now read-only.
Allow a Bottle instance to be passed to Eel #203
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will allow end users to create their own Bottle app and inject any middleware they want, e.g. to handle authentication or session management, before Eel takes over. Resolves #199
samuelhwilliams
added a commit
that referenced
this pull request
Nov 18, 2019
PR #203 added the ability for users to pass a custom Bottle instance to Eel, which was intended to help them add middleware. Unfortunately, the custom app instance has no routing set up and so fundamentally fails to support Eel's functionality. This patch applies the functions that handle routing to any custom bottles before handing off off to bottle to run the server. Fix #211
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow end users to create their own Bottle app and inject any
middleware they want, e.g. to handle authentication or session
management, before Eel takes over.
Resolves #199