Support venv detection on Windows with mingw Python#12545
Support venv detection on Windows with mingw Python#12545bluetech merged 5 commits intopytest-dev:mainfrom
Conversation
lazka
left a comment
There was a problem hiding this comment.
These docs need to be updated too: https://github.com/pytest-dev/pytest/blob/main/doc/en/reference/reference.rst?plain=1#L1705-L1706
I'd guess just removing the " by the presence of an activation script" should be enough. The users shouldn't need to care how it's done.
Otherwise lgtm, code wise.
bluetech
left a comment
There was a problem hiding this comment.
Thanks @zachsnicker, and @lazka for the review.
There was a problem hiding this comment.
I edited this entry a little, in #12559. Preview: https://pytest--12559.org.readthedocs.build/en/12559/changelog.html#improvements-in-existing-functionality.
|
Seems like this is basically breaking pytest support in conda environments, can we revert this change until we've reliably roll out |
|
@jezdez is there a good way to check for conda prior to that change? im happy to roll back for now, but if a consistent bugfix that ensures compatibility with older conda is easy, i'd prefer landing that over a revert dance |
Actually, apologies for responding to a closed PR, can we move that into #12652 please? |
closes #12544
_in_venvfunction insrc/_pytest/main.pyto correctly detect Python virtual environments.testing/test_collection.pyto validate the new behavior.