fix: resolve EncodingWarning in tox upgrade environment #3007
+6
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use locale.getencoding() (Python 3.11+) with fallback for older versions in update_embedded.py. Suppress pip's internal EncodingWarning in upgrade_wheels.py since we cannot modify pip's deprecated API usage. Signed-off-by: Bernát Gábor <bgabor8@bloomberg.net>
0fee0e0 to
a6ae6c1
Compare
This was referenced Jan 7, 2026
This was referenced Jan 14, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
locale.getencoding()(Python 3.11+) with fallback for older versions inupdate_embedded.pyEncodingWarninginupgrade_wheels.pysince we cannot modify pip's deprecated API usageTest plan
tox r -e upgradeand verify no warnings appear