Fixed two GCC-only issues around upb's generated extension registry.#27042
Draft
copybara-service[bot] wants to merge 1 commit intomainfrom
Draft
Fixed two GCC-only issues around upb's generated extension registry.#27042copybara-service[bot] wants to merge 1 commit intomainfrom
copybara-service[bot] wants to merge 1 commit intomainfrom
Conversation
787e53d to
70b1b5a
Compare
01da5b4 to
1024535
Compare
This change refactors the generated `upb_MiniTableExtension` variables to be `const upb_MiniTableExtension*` instead of `const upb_MiniTableExtension`. The linker array now stores pointers to these extension objects. This fixes an issue related to position-independent executables on GCC (see the attached bug for more information). We also unconditionally retain all extensions for the generated registry when compiling under GCC. This effectively disables tree shaking of extensions when compiling with GCC, but fixes a GCC-only compiler error. There may be a way to re-enable linker GC with GCC at some point, but the priority for the moment is just fixing the issue. A new test is added to verify registry loading with no linked extensions. Fixes: #26385 PiperOrigin-RevId: 904021133
1024535 to
93b0900
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed two GCC-only issues around upb's generated extension registry.
This change refactors the generated
upb_MiniTableExtensionvariables to beconst upb_MiniTableExtension*instead ofconst upb_MiniTableExtension. The linker array now stores pointers to these extension objects. This fixes an issue related to position-independent executables on GCC (see the attached bug for more information).We also unconditionally retain all extensions for the generated registry when compiling under GCC. This effectively disables tree shaking of extensions when compiling with GCC, but fixes a GCC-only compiler error. There may be a way to re-enable linker GC with GCC at some point, but the priority for the moment is just fixing the issue.
A new test is added to verify registry loading with no linked extensions.
Fixes: #26385