Repository navigation
fix(client): name Chromium's push AbortError (0.1.3) - #1
Merged
Merged
Conversation
…ission) subscribe() re-threw Chromium's raw 'Registration failed - push service error', which reads like the app failed. It means the browser has no reachable push service: ungoogled Chromium has none, Brave ships with it off. Map it to PushError 'no-push-service' / 'brave-push-off' (with the brave://settings fix), and Chromium's AbortError 'permission denied' to 'denied'. 0.1.3. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
subscribe()passed Chromium's rawRegistration failed - push service errorthrough, which looks like an app failure. It means the browser has no reachable push service: ungoogled-chromium has none at all (reported on agenticjobs.work), and Brave ships with Use Google services for push messaging off.PushError('no-push-service'), or'brave-push-off'with the exact brave://settings/privacy fix whennavigator.braveexistsRegistration failed - permission denied(seen in headless Chrome) →'denied'Same mapping shipped in agenticjobs 0.20.2 (profullstack/agenticjobs#188).
🤖 Generated with Claude Code