Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Dialog footer scrollable on very short viewports #5629

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

hectahertz
Copy link
Contributor

Part of the work to improve reflow of the component. This helps to make all the footer buttons accessible on small screens and gives some extra breathing room to the body.

Changelog

Changed

Dialog footer becomes scrollable on very short viewports.

Before

Screen.Recording.2025-01-30.at.20.46.28.mov

After

Screen.Recording.2025-01-30.at.20.46.08.mov

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

The CSS changes seem a bit esoteric, but are due to overflow: scroll not being compatible with justify-content: flex-end. flex-direction: row-reverse; flex-wrap: wrap-reverse; plus reversing the items is visually equivalent but compatible. The focus order keeps being the same.

Merge checklist

@hectahertz hectahertz requested a review from a team as a code owner January 30, 2025 19:52
@hectahertz hectahertz requested a review from joshblack January 30, 2025 19:52
Copy link

changeset-bot bot commented Jan 30, 2025

🦋 Changeset detected

Latest commit: 212e3da

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Jan 30, 2025
Copy link
Contributor

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 104.48 KB (+0.06% 🔺)
packages/react/dist/browser.umd.js 104.85 KB (+0.02% 🔺)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants