Make Dialog footer scrollable on very short viewports #5629
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of the work to improve reflow of the component. This helps to make all the footer buttons accessible on small screens and gives some extra breathing room to the body.
Changelog
Changed
Dialog footer becomes scrollable on very short viewports.
Before
Screen.Recording.2025-01-30.at.20.46.28.mov
After
Screen.Recording.2025-01-30.at.20.46.08.mov
Rollout strategy
Testing & Reviewing
The CSS changes seem a bit esoteric, but are due to
overflow: scroll
not being compatible withjustify-content: flex-end
.flex-direction: row-reverse; flex-wrap: wrap-reverse;
plus reversing the items is visually equivalent but compatible. The focus order keeps being the same.Merge checklist