Repository navigation
Conversation
`query.cancel()` sent the cancel request on a connection of its own but dropped the promise that request settles, and returned null. A cancel request that failed, for example because that connection could not be opened, was then an unhandled rejection, which ends a Node process by default, and the caller had no way to handle it. Return the promise instead, and the same promise on later calls, which still send no second request. Its type is now `Promise<void>`, and the README says how it settles. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Author
|
I made a few PRs from Claude which fix some problems I was having. Can you take a look? |
colll78
added a commit
to Anastasia-Labs/midgard
that referenced
this pull request
Oct 6, 2026
@effect/sql-pg cancels every running query it interrupts, and postgres.js sends that cancel on a connection of its own, then settles a promise that Query.cancel() drops. When that connection is refused or reset (Postgres restarting or unreachable at that moment), the rejection is unhandled, and a node with no handler for one exits. Extend the postgres 3.4.9 patch, ESM and CommonJS: cancel() sends the request once, handles a rejection of its promise itself and returns the promise, as the open upstream pull request porsager/postgres#1237 does without the handler. postgres.js has no hook to report the failure to; a failed cancel leaves the query running to its end, and the query's own result and failure path are unchanged. No released postgres version fixes this (3.4.9 is the latest). A real-Postgres test resets the cancel connection behind a proxy and checks there is no unhandled rejection and the pool serves the next query.
This was referenced Oct 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
query.cancel()sent the cancel request on a connection of its own but dropped the promise that request settles, and returned null. A cancel request that failed, for example because that connection could not be opened, was then an unhandled rejection, which ends a Node process by default, and the caller had no way to handle it.Return the promise instead, and the same promise on later calls, which still send no second request. Its type is now
Promise<void>, and the README says how it settles.