Skip to content

Conversation

@nerfZael
Copy link
Contributor

@nerfZael nerfZael commented May 9, 2023

  • Fixed an issue with optional env
    It wasn't working because we were encoding an empty object which displayed an encoded size > 0, so deserialization would fail.

  • Implemented a comprehensive test suite for the env feature

  • This PR uses test wrappers from the following PR in the wasm test harness: Env cases refactor wrap-test-harness#64

Test cases:

  • invoke method without env does not require env
  • invoke method without env works with env
  • invoke method with required env works with env
  • invoke method with required env throws without env registered
  • invoke method with optional env works with env
  • invoke method with optional env works without env
  • env can be registered for any uri in resolution path
  • subinvoke method without env does not require env
  • subinvoke method without env works with env
  • subinvoke method with required env works with env
  • subinvoke method with required env throws without env registered
  • subinvoke method with optional env works with env
  • subinvoke method with optional env works without env
  • subinvoker env does not override subinvoked env

@dOrgJelli dOrgJelli merged commit dd43ab5 into origin-dev May 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants