Fix: MultiChainLayerZeroTellerWithMultiAssetSupport add decimal conversion for handling peer vaults with different decimals

[0xhafa]

https://linear.app/plume-network/issue/NPD-310/bnb-vaults-are-18-decimals-and-peer-vaults-ethereum-plume-and-plasma

[Copilot]

Pull Request Overview

This PR adds decimal conversion logic to MultiChainLayerZeroTellerWithMultiAssetSupport to handle cross-chain bridging between vaults with different decimal precision (e.g., 18 decimals on BNB vs other chains). The changes introduce a shared 6-decimal format for cross-chain messages and convert between local and shared decimals during bridging operations.

Key Changes

• Added decimal conversion helper functions (_toLD and _toSD) to convert between local decimals and a shared 6-decimal format
• Updated constructor to accept and store local decimal configuration
• Modified bridge send/receive logic to apply decimal conversions, ensuring consistent precision across chains

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[Copilot]

Pull Request Overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 3 comments.

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[Copilot]

Pull Request Overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[Copilot]

Pull Request Overview

Copilot reviewed 128 out of 131 changed files in this pull request and generated 4 comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

The _toSD function performs integer division which truncates precision. This check only catches when the result is exactly 0, but doesn't handle cases where significant precision is lost due to truncation (e.g., shareAmount = decimalConversionRate - 1 would become 0).

[Copilot]

The array size was reduced from 6 to 3, but the code still assigns to indices 3, 4, and 5 which are now out of bounds. This will cause array access violations.

[Copilot]

Same issue as above - array size reduced to 3 but code tries to access indices beyond the array bounds.

[Copilot]

This function signature change from claimWithdraw(uint256) to claimWithdraw(address, uint256) is a breaking change that could affect existing integrations. Consider versioning or maintaining backwards compatibility.

Suggested change

	}
	}
	/// @deprecated Use claimWithdraw(address, uint256) instead
	function claimWithdraw(uint256 amount) external pure virtual returns (bytes memory addressesFound) {
	// Use msg.sender as the default address
	return claimWithdraw(msg.sender, amount);
	}