Orthographic projection for 3D plots - finalist#3550
Merged
Conversation
adjust ortho camera dist in module and added orthographic mocks adjust camera structure in jasmine test & corrected baselines
archmoj
commented
Feb 18, 2019
package.json
Outdated
| "gl-mesh3d": "^2.0.7", | ||
| "gl-plot2d": "^1.4.2", | ||
| "gl-plot3d": "^1.6.3", | ||
| "gl-plot3d": "git://github.com/gl-vis/gl-plot3d.git#33d5169a62d9b903a8f3a4607f4dae726c4bb57b", |
Contributor
Author
There was a problem hiding this comment.
Contributor
Author
There was a problem hiding this comment.
Also regarding gl-axes3d changes... https://github.com/gl-vis/gl-axes3d/compare/ortho-view1
archmoj
commented
Feb 18, 2019
etpinard
reviewed
Feb 18, 2019
Contributor
|
@archmoj this is starting to look good! Nice work! About
First you'll need to change the plotly.js/src/plots/gl3d/scene.js Lines 800 to 842 in 25fa0c2 to update the projection? |
etpinard
reviewed
Feb 20, 2019
etpinard
reviewed
Feb 20, 2019
etpinard
reviewed
Feb 20, 2019
Contributor
|
Awesome work @archmoj !! Adding this to 💃 💃 💃 |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #3331.
Fixes #2611 by adding orthographic views to Plotly graphs.
A new attribute
orthois defined on the camera object (defaulted tofalse) and passed togl-plot3dandgl-axes3dmodules.The scene initialisation now uses the camera initial vectors as well as
orthoattribute.The createCamera function needed in
plot/gl3d/scene.jsandgl-vis/gl-plot3dis centralised in a separate module (i.e. a fork of3d-view-controlswhile applying Plotly.js camera.js latest changes).Interactive demo.
TODO:
relayoutpath to start new scene when switching betweenorthographicandperspectiveprojections.@plotly/plotly_js
@jackparmer