Skip to content
This repository was archived by the owner on Feb 9, 2019. It is now read-only.

Conversation

@ronaldwidha
Copy link

The readme.md is out of date and causing specifically 2 known issues discussed in the following threads:

In summary, in Play 2.4.2, the current readme causes an exception to be thrown upon setting up @Inject on JedisPool. The correct dependency is play-plugin-redis 2.4.1 (instead of 2.4.0).

Also, since all other dependencies need to participate in the dependency injection to obtain JedisPool via @Inject, I believe it is beneficial for new users to have this piece of information explicitly called out as part of the getting started step.

For Play 2.4.2, the current readme causes an exception to be thrown upon setting up @Inject on JedisPool. The correct dependency is play-plugin-redis 2.4.1 see playframework#156 and playframework#157
@lightbend-cla-validator

Hi @ronaldwidha,

Thank you for your contribution! We really value the time you've taken to put this together.

Before we proceed with reviewing this pull request, please sign the Typesafe Contributors License Agreement:

http://www.typesafe.com/contribute/cla

@ronaldwidha ronaldwidha closed this Aug 4, 2015
@ronaldwidha ronaldwidha reopened this Aug 4, 2015
@ronaldwidha
Copy link
Author

I've signed the agreement.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

guice-servlet shouldn't be needed - Play depends on Guice out of the box, you shouldn't need an explicit dependency on it, and you definitely shouldn't need to bring in the servlet API.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants