br: ensure schemaLease is the normal (45s) instead of test value (1s)#66092
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
e767af5 to
89f94a7
Compare
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThis change sets the default schema lease early during BR's TiDB glue initialization by importing Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~5 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #66092 +/- ##
================================================
+ Coverage 77.6919% 78.9225% +1.2306%
================================================
Files 2008 1946 -62
Lines 549590 539382 -10208
================================================
- Hits 426987 425694 -1293
+ Misses 120943 112653 -8290
+ Partials 1660 1035 -625
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
89f94a7 to
f2a448e
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Leavrth, YuJuncen The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
nogo: missing strict dependencies: |
|
/test pull-integration-e2e-test |
|
@kennytm: PRs from untrusted users cannot be marked as trusted with DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
In response to a cherrypick label: new pull request created to branch |
What problem does this PR solve?
Issue Number: close #66110
Problem Summary: Without calling
session.SetSchemaLease, BR will use the default schema lease duration of 1s which is only intended for testing, not production. When the PD TSO somehow lags the BR wall clock by over 0.5s (1/2 of schemaLease) it will not be able to leave the schema reload loop.What changed and how does it work?
Call
session.SetSchemaLeasewith the default lease (45s) when the glue is initialized, which is invoked on start-up for standalone BR.Check List
Tests
br restore pointafter applying this fix.Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.
Summary by CodeRabbit