Micro-optimisation: Change from spl_object_hash() to _id() - #6926
Merged
Conversation
Member
|
Thank you! 👌 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes in this pull request
Resolves no specific issue. However, I am currently having trouble with performance with the Navigation system. While hunting down the reason for my problems I found some quick micro-optimisations which could be done.
Moving from
spl_object_hash()tospl_object_id()should be faster by skipping XOR:ing and using integers rather than strings (polyfill exists). I could see some memory gains (250kB/request with a large menu).Using the root namespace (e.g. symfony/symfony#21020) for the
splfunction saved two steps of stack trace for each call when Opcache was active, performance improvements was a few hundreds of a second for the request, so it did not do much. But it all adds up. :)