Skip to content

Conversation

@devnexen
Copy link
Member

No description provided.

@Ayesh
Copy link
Member

Ayesh commented Aug 16, 2024

LGTM :) :(

@devnexen devnexen linked an issue Aug 16, 2024 that may be closed by this pull request
@cmb69
Copy link
Member

cmb69 commented Aug 16, 2024

Doesn't this need to be added to _php_curl_setopt(), too? Note that it is about a new option, not only an option value.

@devnexen
Copy link
Member Author

devnexen commented Aug 16, 2024

that's right I missed that. cheers

devnexen added a commit to devnexen/php-src that referenced this pull request Aug 16, 2024
devnexen added a commit to devnexen/php-src that referenced this pull request Aug 16, 2024
Copy link
Member

@cmb69 cmb69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! This looks good to me.

The CI failures are unrelated to this PR; more likely caused by #15408.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for CURLOPT_TCP_KEEPCNT (available since curl 8.9.0)

3 participants