Skip to content

Conversation

@ndossche
Copy link
Member

@ndossche ndossche commented Mar 7, 2024

I chose "object" as that's also the argument name in WeakReference::create.

@ndossche ndossche requested a review from iluuu1994 as a code owner March 7, 2024 20:20
@ndossche ndossche linked an issue Mar 7, 2024 that may be closed by this pull request
Copy link
Member

@iluuu1994 iluuu1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @nielsdos!

@ndossche ndossche merged commit d6d3370 into php:master Mar 8, 2024
ndossche added a commit to ndossche/php-src that referenced this pull request Mar 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dump wrapped object in WeakReference class

2 participants