Documenting the changes to syslog.filter #589
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
php/php-src#4265 restored the previous handling of multi-line log messages by adding `syslog.filter=raw`.
This comment has been minimized.
This comment has been minimized.
Highlight the fact that line splitting is happening in all of the three original modes, but not in "raw".
One can argue that this filter option is an incompatible change, because it forced logging to always splitt lines.
Contributor
Author
|
I hope this does not mess up anything unexpectedly. I was trying to recreate what other places use for the same effect. :) |
cmb69
reviewed
May 10, 2021
Member
cmb69
left a comment
There was a problem hiding this comment.
Besides the nit, this looks good to me. Thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
php/php-src#4265 restored the previous handling of multi-line log messages by adding
syslog.filter=raw.Relates to https://bugs.php.net/bug.php?id=77913