Wrap example output in CDATA - #2736
Merged
Merged
Conversation
TimWolla
approved these changes
Sep 2, 2023
TimWolla
left a comment
Member
There was a problem hiding this comment.
Interesting. Without the CDATA the output is not wrapped in a <pre>. I wonder if this is a bug in PHD? In any case this change also makes sense for consistency. I'd like to have another pair of eyes on this, though.
Girgias
approved these changes
Sep 2, 2023
Member
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://www.php.net/manual/en/tutorial.useful.php
The output of the first example includes an initial new line.
The script to generate this output will not generate a newline. Here is the output of the given script:
Wrapping in CDATA, which seems to be the pattern used for
screentags, fixes this.