Skip to content

improved xpath that matches related elements - #621

Closed
oleg-andreyev wants to merge 0 commit into
php-webdriver:communityfrom
oleg-andreyev:adjust-getRelatedElements
Closed

improved xpath that matches related elements#621
oleg-andreyev wants to merge 0 commit into
php-webdriver:communityfrom
oleg-andreyev:adjust-getRelatedElements

Conversation

@oleg-andreyev

@oleg-andreyev oleg-andreyev commented Dec 31, 2018

Copy link
Copy Markdown
Contributor

It's possible to put into a form, but Element will be associated with a different form

Ref.: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/input#form

@oleg-andreyev

Copy link
Copy Markdown
Contributor Author

@gfosco @OndraM could you please take a look, thanks in advance

@OndraM

OndraM commented Jun 9, 2019

Copy link
Copy Markdown
Collaborator

These classes were recently contributed by @dunglas - maybe he can have have a look as well, please?

@dunglas dunglas left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OndraM
OndraM force-pushed the adjust-getRelatedElements branch from 944aa2a to 0080c9f Compare June 9, 2019 18:33
@OndraM

OndraM commented Jun 9, 2019

Copy link
Copy Markdown
Collaborator

Rebased against current community branch; will be merged after CI build finishes.

@OndraM
OndraM self-requested a review June 9, 2019 20:11
@OndraM

OndraM commented Jun 9, 2019

Copy link
Copy Markdown
Collaborator

Well, according to Coveralls, these lines are now uncovered by tests:
https://coveralls.io/builds/23884998/source?filename=lib%2FAbstractWebDriverCheckboxOrRadio.php#L215

But they were covered in latest community branch build: https://coveralls.io/builds/23884443/source?filename=lib/AbstractWebDriverCheckboxOrRadio.php

Is this now a dead code, bug in the implementation or false positive in the coverage report?

@OndraM

OndraM commented Jun 10, 2019

Copy link
Copy Markdown
Collaborator

Ok, it seems unrelated to this pull-request. However I extended the testcases to cover this as well.

@OndraM OndraM closed this Jun 10, 2019
@OndraM
OndraM force-pushed the adjust-getRelatedElements branch from f73c0ed to d1ad0b1 Compare June 10, 2019 13:57
@OndraM

OndraM commented Jun 10, 2019

Copy link
Copy Markdown
Collaborator

Merged to community branch manually, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants