Skip to content

feat(ui): adds dashed button style#15728

Merged
JarrodMFlesch merged 4 commits intomainfrom
chore/button-styles
Feb 23, 2026
Merged

feat(ui): adds dashed button style#15728
JarrodMFlesch merged 4 commits intomainfrom
chore/button-styles

Conversation

@JarrodMFlesch
Copy link
Copy Markdown
Contributor

@JarrodMFlesch JarrodMFlesch commented Feb 23, 2026

This PR adds a new dashed button style property.

Changes:

  • removes box-shadow from buttons and replaces it with border
    • adds "always on" 1px solid transparent border
    • reduces line-height by 2px from calc(var(--base) * 1.2) to calc(var(--base) * 1.1) (.1 --base is 2px) to account for new "always on" border

Fixes button with icon-only had incorrect padding set, should be equal left and right.

Adds custom page in the admin test suite /admin/button-styles so we can quickly see all button variations. (as you can see we support styles that do not have any default styles, like error). Updating all of those is out of scope for this PR but I think this custom view will help us with button updates in the future.

CleanShot 2026-02-23 at 11 15 45

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 23, 2026

📦 esbuild Bundle Analysis for payload

This analysis was generated by esbuild-bundle-analyzer. 🤖
This PR introduced no changes to the esbuild bundle! 🙌

@JarrodMFlesch JarrodMFlesch changed the title fix(ui): incorrect --icon-only button padding feat(ui): adds dashed button style Feb 23, 2026
@JarrodMFlesch JarrodMFlesch merged commit d570787 into main Feb 23, 2026
306 of 308 checks passed
@JarrodMFlesch JarrodMFlesch deleted the chore/button-styles branch February 23, 2026 17:18
JarrodMFlesch added a commit that referenced this pull request Feb 23, 2026
The list selection had it's own `border: none` which overwrote the
un-hovered state of the selection buttons. This is unnecessary and arose
from #15728.
@github-actions
Copy link
Copy Markdown
Contributor

🚀 This is included in version v3.78.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants