Merged
Conversation
* This directive includes Add To Cart functionality directly from Product List OC-2063
These two views are always showing the placeholder image for products, even when the product has an image in it's extended properties. OC-2151 #51
display missing images on review and confirmation
object needed to be stringified by ocParameters.Create OC-2153 #49
also update code to align with our code standards F51-122
fix broken unit tests and add tests for FavoriteProductsCtrl F51-122
bugFix: refine by favorite products causes error
update unit tests for favoriteProducts
Only remove cookies that have the application's cookiePrefix The cookiePrefix is `ocAppName.Watch().replace(/ /g, '_').toLowerCase();`
Update the select spending account modal title to be "Select Spending Account" instead of "New Address"
this bug is related to recent breaking changes. list call is expecting a parameter `search` and is instead receiving `searchTerm`. F51-153
F51-123 Update Auth.Logout()
Fix search - not filtering on hard enter
if there are multiple parents (i.e. fromState.parent does not equal toState.parent, then fallback to base to host loading indicators
Hide travis badges until our unit tests are refactored
These two views are always showing the placeholder image for products, even when the product has an image in it's extended properties. OC-2151 #51
object needed to be stringified by ocParameters.Create OC-2153 #49
also update code to align with our code standards F51-122
fix broken unit tests and add tests for FavoriteProductsCtrl F51-122
Only remove cookies that have the application's cookiePrefix The cookiePrefix is `ocAppName.Watch().replace(/ /g, '_').toLowerCase();`
this bug is related to recent breaking changes. list call is expecting a parameter `search` and is instead receiving `searchTerm`. F51-153
F51-208 unit test for myAddresses component
Oc 2101 mini cart badge
- When app.constants.json > anonymous is set to true, the ocRefreshToken service will attempt to authorize anonymously using the current clientid and scope constants. - An error will be logged to the console if the clientid is not configured to work with anonymous authentication.
- Storing these tokens will trigger the refresh token workflow which does not correspond to an anonymous authentication. - Comments have been added in the code explaining why we do not store the refresh tokens from the anonymous auth response.
* the forgot your password flow was hitting a deprecated endpoint. * updated $stateParams from token to validationCode for clarity. token was what was previously being passed in, but new method now uses validation code F51-240
clarity mistakenly used validationCode F51-240
update forgot your password for post-bbc endpoint
F51-257 - Cart badge count is displaying incorrectly
- The /register component has been added. Anonymous users can access this at any time to profile themselves. - The /login controller has been updated to merge anon orders with profiled users most recent unsubmitted order - Checkout state has a resolve for opening up the ocAnonymous Identify modal which will force anon users to either login or register before continuing to checking out. - ocAnonymous has a "Redirect" function for sending the newly profiled user to the state that was passed into the .Identify() modal (usually "checkout.shipping" but it could be anything)
- Redirect back to cart after force profiling - Remove the redirect cookie after a successful ocAnonymous.Redirect() - Block the registration state from non-anonymous users & applications - Fix undefined error blocking ocStateLoading from completing - Add a redirectState argument to ocRefreshToken() for controlling where the user is sent to after the new token is retrieved. - Registration form validation for username conflicts.
F51-214, F51-222 Anonymous Shopping
- All password matching is now handled by the ocMatchField directive. The error message can be customized by using the angular-auto-validate *-err-type="" attribute directive. This is so we can use ocMatchField for more than just passwords.
this keeps it consistent with the other constants in app.constants.json F51-272
F51-267 - Remove confirmPassword directive
expose anonymous constant as heroku variable
In an effort to build our default buying experience using the minimal number of roles, remove the need for UserGroupReader and ApprovalReader when viewing orders awaiting your approval.
F51-154 & F51-276 Order Approvals refactor
robertsoniv
approved these changes
May 18, 2017
crhistianramirez
pushed a commit
to Four51/demo-angular-buyer
that referenced
this pull request
Aug 3, 2017
…_new restore cacheDirectories to empty array.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.