Skip to content

F51-154 & F51-276 Order Approvals refactor#93

Merged
crhistianramirez merged 2 commits intoordercloud-api:developmentfrom
robertsoniv:development
May 18, 2017
Merged

F51-154 & F51-276 Order Approvals refactor#93
crhistianramirez merged 2 commits intoordercloud-api:developmentfrom
robertsoniv:development

Conversation

@robertsoniv
Copy link
Contributor

In an effort to build our default buying experience using the minimal number of roles, remove the need for UserGroupReader and ApprovalReader when viewing orders awaiting your approval.

Summary of changes:
Functional

  • Remove oc-if-roles on Order List > Awaiting My Approval tab
  • Default links to All Orders so that they go straight to the Order History tab
  • Remove the Order Detail > Approvals tab
    • The entire /myOrders/approvals directory has been removed
    • The UpdateOrderApproval method is now in /myOrders/orders/orders.service.js
    • The approval modal controller and template also reside in /myOrders/orders
  • Remove favorite orders toggle from orders that are awaiting the current users approval
  • If the order is awaiting the current users approval, display Approve & Decline buttons on the detail page
  • When an order is approved or declined, return to the Order List > Awaiting My Approval tab
  • Remove the ocOrderDetails service, listing buyers is not possible using shopper roles
  • Add clear buttons for fromDate & toDate if they have a value
  • Clear filters when switching tabs on order list
  • Display a readonly input for Status on the Order List > Awaiting My Approval tab
  • Hide the favorite button column on Order List > Awaiting My Approval tab

Design

  • Add colored icons for each order status on the order list and detail pages
    • .success, .danger, .warning, .info is now usable on .fa icons to color them with brand colors (added to shame.less)
  • Approval Modal submit button is now based on the approvers intent (Approve, Decline)
  • Display order approvals beneath the order status as an unordered list
    • This should read as "Rob Watt declined on DATE" (linebreak) "COMMENTS"

In an effort to build our default buying experience using the minimal
number of roles, remove the need for UserGroupReader and ApprovalReader
when viewing orders awaiting your approval.
@crhistianramirez crhistianramirez merged commit f7494bd into ordercloud-api:development May 18, 2017
crhistianramirez pushed a commit to Four51/demo-angular-buyer that referenced this pull request Aug 3, 2017
…_new

try to force cache clean for bower dependencies
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants