Oc 2101 mini cart badge#83
Merged
crhistianramirez merged 6 commits intoordercloud-api:developmentfrom May 16, 2017
Merged
Conversation
crhistianramirez
requested changes
May 16, 2017
src/app/base/js/base.controller.js
Outdated
| $rootScope.$on('OC:UpdateTotalQuantity', function(event, lineItems, add, difference) { | ||
| if (lineItems.length >= 1) { | ||
| var quantities = _.pluck(lineItems, 'Quantity'); | ||
| return vm.totalQuantity = quantities.reduce(function(a, b) {return a + b}, 0); |
Contributor
There was a problem hiding this comment.
doesn't make sense to put a return here because its not a function thats returning something, its just executing something in response to an event.
Contributor
There was a problem hiding this comment.
same with the other returns in this block
crhistianramirez
approved these changes
May 16, 2017
crhistianramirez
pushed a commit
to Four51/demo-angular-buyer
that referenced
this pull request
Aug 3, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Display total quantity of products in cart, as opposed to total line items in cart