Merged
Conversation
- Remove FavoriteProductCtrl - Change to Attribute directive - Rename to ocFavoriteProduct - Dynamic class added if favorite - Dynamic class added if not favorite
- Remove productQuickView component - Update oc-product-card.html
…ar-buyer into development # Conflicts: # src/app/common/directives/oc-product-card/oc-product-card.html
… file path in template compiled in directive
* previously: ocRepeatOrder, renamed: ocReorder * this element has no template, and is simply an attribute that can be added to any element * includes a loading indicator built-in that will attach itself to any element the directive is on F51-151
this service is used by the ocReorder directive We were previously recursively getting all of the user’s products in order to compare against and determine whether products were valid. Now we will attempt to get products from previous order only, any that are not returned are deemed “invalid” F51-187
attribute directives can’t have their own controller. The openReorderModal logic will now live in the service and the only controller needed will be the modal controller F51-151
docs were pretty outdated, plus usage is a little bit different now that it is an functional (attribute) directive. F51-151
refactor reorder directive F51-151
Users will now copy and paste their verification code from the email they recieve after using the forgot password form.
- Update change password pattern - Encode password before sending to SDK
refactor: update to longhand description that way its consistent with heroku's default value (production)
F51-539 - Use ng-bind-html for product description
call ocRefresh if token is expired
- This will allow us to show embeded content like youtube videos and images
F51-550 Allow embedded videos in product description
* Add flexbox to navbar * Fill all available space with search UI * Add min-width to typeahead results * Remove vestigial code F51-105, F51-109
Optimize search UI
* F51-386 feat: add slick carousel template for multiple product images * F51-386 feat: repeat over product.xp.Images * F51-386 refactor: comment out responsive breakpoint, add infinite false to slick carousel * F51-386 refactor: add template request to directive * F51-386 chore: add angular-ez-plus, zoom library * F51-386 refactor: add timeout function in directive * F51-386 feat: product zoom using ez-plus directive * reset branch to previous commit * reset branch to previous commit * refactor: wrap template request in timeout, add center-mode attr to slick carousel nav * refactor: add modal for product images F51-386 * refactor: update the slick carousel usage to a directive * refactor: move product images carousel and modal functionality into directive F51-386 * F51-386 feat: add zoom directive (wip) for products * F51-386 refactor: update code to reflect data structure of additional images on product * F51-386 refactor: add conditional to open zoom modal if zoom enabled on product * F51-386 refactor: remove use of oc-zoom directive * F51-386 refactor: remove scope injection * F51-386 refactor: move inline style on thumbnail for product slider to less file * F51-386 refactor: remove empty style declaration * F51-386 refactor: remove commented out code * F51-386 refactor: move single image to images directive, update modal to be compatible with one image * F51-386 refactor: remove inline style * F51-386 refactor: remove redundant style, fix size on modal config
* F51-386 feat: add slick carousel template for multiple product images * F51-386 feat: repeat over product.xp.Images * F51-386 refactor: comment out responsive breakpoint, add infinite false to slick carousel * F51-386 refactor: add template request to directive * F51-386 chore: add angular-ez-plus, zoom library * F51-386 refactor: add timeout function in directive * F51-386 feat: product zoom using ez-plus directive * reset branch to previous commit * reset branch to previous commit * refactor: wrap template request in timeout, add center-mode attr to slick carousel nav * refactor: add modal for product images F51-386 * refactor: update the slick carousel usage to a directive * refactor: move product images carousel and modal functionality into directive F51-386 * F51-386 feat: add zoom directive (wip) for products * F51-386 refactor: update code to reflect data structure of additional images on product * F51-386 refactor: add conditional to open zoom modal if zoom enabled on product * F51-386 refactor: remove use of oc-zoom directive * F51-386 refactor: remove scope injection * F51-386 refactor: move inline style on thumbnail for product slider to less file * F51-386 refactor: remove empty style declaration * F51-386 refactor: remove commented out code * F51-386 refactor: move single image to images directive, update modal to be compatible with one image * F51-386 refactor: remove inline style * F51-386 refactor: remove redundant style, fix size on modal config
Fix typo in product quick view modal
* minimize product detail images markup * clean up product detail images styles * begin to refactor full screen modal * add styles for lightbox modal F51-484
* scope styles for homepage slider * WIP: sync styles for carousel and slick sliders F51-484
* this will display the single image with same styles applied as an image in a carousel F51-484
* these have been refactored into a more generic full screen modal class f51-484
design: design for product detail image display
Clean up for the product image display
# Conflicts: # src/app/productDetail/js/productDetail.images.directive.js # src/app/productDetail/templates/productDetail.images.html # src/app/productDetail/templates/productDetail.images.modal.html # src/app/styles/components/_carousel.less
robertsoniv
approved these changes
Jun 20, 2017
amrarick26
pushed a commit
to amrarick26/angular-buyer
that referenced
this pull request
Jul 11, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Angular Buyer v1.0.1