Add some basic unit tests for KNN #212
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…row an exception as documented by the API Signed-off-by: Geoffrey Stewart <[email protected]>
Craigacp
previously approved these changes
Jan 24, 2022
Member
Craigacp
left a comment
There was a problem hiding this comment.
Looks good, thanks. I'll merge it once you've removed the TODO comment.
Common/NearestNeighbour/src/test/java/org/tribuo/common/nearest/TestKNN.java
Outdated
Show resolved
Hide resolved
Craigacp
pushed a commit
that referenced
this pull request
Mar 25, 2022
* Add some basic unit tests for KNN and adjust the predict method to throw an exception as documented by the API Signed-off-by: Geoffrey Stewart <[email protected]> * remove the todo comment Co-authored-by: Geoffrey Stewart <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add some basic unit tests for KNN and adjust the predict method to throw an exception as documented by the API.
Signed-off-by: Geoffrey Stewart [email protected]
Description
A standard set of unit tests is being added for the k-nearest neighbor implementation
Motivation
Adding these unit tests illustrates the use of this functionality and provides some checks in case there are any changes made to the KNN feature in the future.