Updates for the reproducibility changes in the rest of Tribuo #190
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated the copyrights everywhere to include the correct year. - Shortened the setInvocationCount idiom. - Fixed a few bugs where the invocation count updated the wrong variable. - Added support for setting the invocation count to classifier chains.
pogren
approved these changes
Oct 28, 2021
Member
pogren
left a comment
There was a problem hiding this comment.
this all looks straightforward.
more consistent naming of member variable trainInvocationCount (from invocationCount) and more succinct handling of it in respective setInvocationCount methods,
- make setInvocationCount methods synchronized
- SparseModel.train now has a default implementation for the method that takes an invocationCount
- ClassifierChainTrainer has its own train method that takes invocationCount
- misc. non-code edits - e.g. updated copyright statements, fixed typos
| trainInvocationCounter++; | ||
|
|
||
| for (trainInvocationCounter = 0; trainInvocationCounter < invocationCount; trainInvocationCounter++){ | ||
| SplittableRandom localRNG = rng.split(); |
Member
There was a problem hiding this comment.
this creates an "unused variable" compiler warning in my IDE. Do you care?
Member
Author
There was a problem hiding this comment.
For the localRNG? That's what I get in intellij, but it's intentional, it's the only way to advance the rng to the right state. I'm not sure if there is a suppress warning flag that will work across all IDEs, but if there is we can do that. We'll need to do something for the static analysis too, but that can be a problem for another day.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation
Tidying up a few things after the large merge.