Fixing a bug where MultiLabelConfusionMatrix swapped FP for FN #167
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pogren
reviewed
Sep 1, 2021
Member
pogren
left a comment
There was a problem hiding this comment.
It looks like the class-level javadoc comments for MultiLabelConfusionMatrix still have the indices backwards.
Member
Author
Fixed, thanks. |
pogren
approved these changes
Sep 7, 2021
Member
pogren
left a comment
There was a problem hiding this comment.
This is a straightfoward bug fix that corrects the indices used for retrieving FPs and FNs from the underlying matrix used in MultiLabelConfusionMatrix (i.e. the "fp" and "fn" methods). Now the values used match the way the data is entered in the tabulate method. The only other changes are minor javadoc edits and fixing the assertion values in the unit test.
Craigacp
added a commit
that referenced
this pull request
Oct 1, 2021
* Fixing a bug where MultiLabelConfusionMatrix swapped FP for FN. * Fixing the class level javadoc for MultiLabelConfusionMatrix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The multilabel evaluation package swapped the FPs for FNs when accessing them, causing many of the metrics to be permuted incorrectly producing incorrect values for precisions, recalls and the evaluation.toString().
Motivation
It's best if the evaluations report the right numbers in the right places.