Added support for multioutputs to ResponseProcesser, with tests. #150
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should allow us to convert CSVLoader to use CSVDataSource as its backend, increasing consistency and simplicity.
…rocessor` if response fields were missing from the input rows.
… use `=` to match usage in `MultiLabel`
Craigacp
requested changes
Jul 13, 2021
Member
Craigacp
left a comment
There was a problem hiding this comment.
Bunch of small things and a couple of correctness issues.
Data/src/main/java/org/tribuo/data/columnar/ResponseProcessor.java
Outdated
Show resolved
Hide resolved
Data/src/main/java/org/tribuo/data/columnar/ResponseProcessor.java
Outdated
Show resolved
Hide resolved
Data/src/main/java/org/tribuo/data/columnar/ResponseProcessor.java
Outdated
Show resolved
Hide resolved
Data/src/main/java/org/tribuo/data/columnar/processors/response/BinaryResponseProcessor.java
Outdated
Show resolved
Hide resolved
Data/src/main/java/org/tribuo/data/columnar/processors/response/BinaryResponseProcessor.java
Outdated
Show resolved
Hide resolved
Data/src/main/java/org/tribuo/data/columnar/processors/response/QuartileResponseProcessor.java
Outdated
Show resolved
Hide resolved
Data/src/main/java/org/tribuo/data/columnar/processors/response/QuartileResponseProcessor.java
Show resolved
Hide resolved
Data/src/main/java/org/tribuo/data/columnar/processors/response/QuartileResponseProcessor.java
Show resolved
Hide resolved
Data/src/main/java/org/tribuo/data/columnar/processors/response/QuartileResponseProcessor.java
Outdated
Show resolved
Hide resolved
...test/java/org/tribuo/data/columnar/processors/response/MultioutputResponseProcessorTest.java
Outdated
Show resolved
Hide resolved
Member
Author
|
I believe I've addressed all the changes requested with this commit, let me know if I missed something. |
Craigacp
requested changes
Jul 14, 2021
Member
Craigacp
left a comment
There was a problem hiding this comment.
I think the quartile one needs another look to make sure the behaviour hasn't changed, but otherwise it's pretty close.
Data/src/main/java/org/tribuo/data/columnar/ResponseProcessor.java
Outdated
Show resolved
Hide resolved
Data/src/main/java/org/tribuo/data/columnar/processors/response/BinaryResponseProcessor.java
Outdated
Show resolved
Hide resolved
Data/src/main/java/org/tribuo/data/columnar/processors/response/QuartileResponseProcessor.java
Outdated
Show resolved
Hide resolved
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes
ResponseProcessors to process response inputs for multiple fields, supporting things like multilabel or multiclass classification.Motivation
This is a new feature that extends the generality of the
org.tribuo.data.columnarsystem, but the direct motivation is to allowCSVLoaderto become a special case ofCSVDataSource, by supporting all of the features ofCSVLoaderwithinColumnarDataSource.