Skip to content

Conversation

@bastien-phi
Copy link
Contributor

Another way to fix the deprecations in to add return types.

Let me know if you prefer this way

@mdumoulin
Copy link

Hi @msarca @sorinsarca and thanks @bastien-phi. The fix seems alright to me and similar to chosen solution in json-schema : opis/json-schema#96. Can we expect a merge soon ?

@sorinsarca sorinsarca merged commit 9ebf1a1 into opis:master Jan 14, 2022
@sorinsarca
Copy link
Member

Released in v2.0.1

@mdumoulin
Copy link

@sorinsarca Thanks !

@bastien-phi bastien-phi deleted the php8.1 branch January 15, 2022 19:00
@matiux
Copy link

matiux commented Jan 16, 2022

Same error with opis/string 2.0.1

  1x: Method "ArrayAccess::offsetSet()" might add "void" as a native return type declaration in the future. Do the same in implementation "Opis\String\UnicodeString" now to avoid errors or add an explicit @return annotation to suppress this message.

  1x: Method "ArrayAccess::offsetUnset()" might add "void" as a native return type declaration in the future. Do the same in implementation "Opis\String\UnicodeString" now to avoid errors or add an explicit @return annotation to suppress this message.

@ricky-rockstar
Copy link

Same error with opis/string 2.0.1

  1x: Method "ArrayAccess::offsetSet()" might add "void" as a native return type declaration in the future. Do the same in implementation "Opis\String\UnicodeString" now to avoid errors or add an explicit @return annotation to suppress this message.

  1x: Method "ArrayAccess::offsetUnset()" might add "void" as a native return type declaration in the future. Do the same in implementation "Opis\String\UnicodeString" now to avoid errors or add an explicit @return annotation to suppress this message.

Is this going to be fixed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants