Skip to content

Conversation

@k-yle
Copy link
Collaborator

@k-yle k-yle commented Jul 1, 2024

This PR renders the side=* tag, similar to how direction=* is rendered.

side=* is used with highway=cyclist_waiting_aid, but it is currently slow and tricky to use this tag. This PR aims to make it much more intuitive to map the side. It can be tested from here.

@k-yle k-yle added the map-renderer An issue with how things are rendered in the map label Jul 1, 2024
);
results.push({
type: isSide ? 'side' : 'direction',
angle: (geoAngle(this, resolver.entity(nodeId), projection) * (180 / Math.PI)) + (isSide ? 0 : 90)
Copy link
Collaborator

@1ec5 1ec5 Jul 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea, though I wonder if reusing the “cone” would risk confusing some users. Some mappers are also using side=* on traffic_signals=* vertices. This change will cause these vertices’ cones to point away from the street, which would be inconsistent with the cones for standalone traffic_signals=* nodes. Plus, it might be necessary to combine side=* with direction=* in some cases. In the screenshot above, this would imply four different “faces” rather than two. Maybe side=* could act as more of a mask, chopping the directional cone in half?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was wondering about how to visualize the side as well.

The direction is more of a "looking direction" or "affected area".

But the side is more of "an anchor" or a "connection point" or a "this belongs to over there" indicator. However I don't see a way to visualize those well. Especially when the actual "anchor point" is unknown (we only now "it is to the right").

The other UI we use to show direction of elements is on barrier=retaining_wall and such with the small arrows next to the line. Maybe this is something we can build upon for this UI? Like one of those arrows next to the node?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like one of those arrows next to the node?

Something like … image?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea, though I wonder if reusing the “cone” would risk confusing some users.
[...]
Maybe side=* could act as more of a mask, chopping the directional cone in half?

That's a cool idea, although it might be confusing if side+direction renders differently to side and direction on their own? Here's what it could look like:

:
:

Like one of those arrows next to the node?

Something like this maybe?

:
:
:
:
T:

Any other ideas would be greatly appreciated...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the 👍

Copy link
Member

@tyrasd tyrasd Jan 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another way to do it could be to shift the vertex icon itself to the side, like this:


But I don't think that looks good and could be even confusing (e.g. it's unclear where other objects would snap to, etc.).

@tyrasd
Copy link
Member

tyrasd commented Jan 15, 2025

For cyclist waiting aids the side tag is working a bit differently than normal side tags. 🙈 We need to check if this rendering is working for them as documented on the wiki.

@k-yle
Copy link
Collaborator Author

k-yle commented Jul 4, 2025

Following a discussion last week, we will not render the side tag for highway=cyclict_waiting_aid on a bidirectional cycleway, because the wording in the proposal is too ambiguous 😕 I wanted to fix the definition a year ago, but now it's too late...

@tyrasd tyrasd merged commit 532880f into openstreetmap:develop Sep 1, 2025
3 checks passed
hlfan added a commit to hlfan/iD that referenced this pull request Sep 3, 2025
@k-yle k-yle deleted the side branch September 9, 2025 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

map-renderer An issue with how things are rendered in the map

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants