Skip to content

Conversation

@levitte
Copy link
Member

@levitte levitte commented Aug 11, 2025

The last hex digit always became 0x0L, even of OPENSSL_VERSION_PRE_RELEASE
was the empty string.

Resolves: #28227

The last hex digit always became 0x0L, even of OPENSSL_VERSION_PRE_RELEASE
was the empty string.

Resolves: openssl#28227
@levitte levitte added branch: master Applies to master branch approval: review pending This pull request needs review by a committer triaged: bug The issue/pr is/fixes a bug tests: exempted The PR is exempt from requirements for testing branch: 3.2 Applies to openssl-3.2 (EOL) branch: 3.3 Applies to openssl-3.3 branch: 3.4 Applies to openssl-3.4 branch: 3.5 Applies to openssl-3.5 labels Aug 11, 2025
@levitte
Copy link
Member Author

levitte commented Aug 11, 2025

This is a pretty minor bug, as I see it.

@levitte levitte added the style: waived exempted from style checks label Aug 11, 2025
@levitte
Copy link
Member Author

levitte commented Aug 11, 2025

Waving the style check, 'cause it's nonsense on .h.in files.

@github-actions github-actions bot added the severity: fips change The pull request changes FIPS provider sources label Aug 11, 2025
Copy link
Member

@InfoHunter InfoHunter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed that nonsense for such a file to check style.

@paulidale paulidale added approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer labels Aug 12, 2025
@openssl-machine openssl-machine added approval: ready to merge The 24 hour grace period has passed, ready to merge and removed approval: done This pull request has the required number of approvals labels Aug 13, 2025
@openssl-machine
Copy link
Collaborator

This pull request is ready to merge

openssl-machine pushed a commit that referenced this pull request Aug 13, 2025
The last hex digit always became 0x0L, even of OPENSSL_VERSION_PRE_RELEASE
was the empty string.

Resolves: #28227

Reviewed-by: Paul Yang <[email protected]>
Reviewed-by: Paul Dale <[email protected]>
(Merged from #28230)
openssl-machine pushed a commit that referenced this pull request Aug 13, 2025
The last hex digit always became 0x0L, even of OPENSSL_VERSION_PRE_RELEASE
was the empty string.

Resolves: #28227

Reviewed-by: Paul Yang <[email protected]>
Reviewed-by: Paul Dale <[email protected]>
(Merged from #28230)

(cherry picked from commit ba2c314)
openssl-machine pushed a commit that referenced this pull request Aug 13, 2025
The last hex digit always became 0x0L, even of OPENSSL_VERSION_PRE_RELEASE
was the empty string.

Resolves: #28227

Reviewed-by: Paul Yang <[email protected]>
Reviewed-by: Paul Dale <[email protected]>
(Merged from #28230)

(cherry picked from commit ba2c314)
openssl-machine pushed a commit that referenced this pull request Aug 13, 2025
The last hex digit always became 0x0L, even of OPENSSL_VERSION_PRE_RELEASE
was the empty string.

Resolves: #28227

Reviewed-by: Paul Yang <[email protected]>
Reviewed-by: Paul Dale <[email protected]>
(Merged from #28230)

(cherry picked from commit ba2c314)
openssl-machine pushed a commit that referenced this pull request Aug 13, 2025
The last hex digit always became 0x0L, even of OPENSSL_VERSION_PRE_RELEASE
was the empty string.

Resolves: #28227

Reviewed-by: Paul Yang <[email protected]>
Reviewed-by: Paul Dale <[email protected]>
(Merged from #28230)

(cherry picked from commit ba2c314)
@levitte levitte added the branch: 3.0 Applies to openssl-3.0 branch label Aug 13, 2025
@levitte
Copy link
Member Author

levitte commented Aug 13, 2025

Merged

master:
ba2c314 Correct the synthetisized OPENSSL_VERSION_NUMBER

3.5:
229bc34 Correct the synthetisized OPENSSL_VERSION_NUMBER

3.4:
21e1202 Correct the synthetisized OPENSSL_VERSION_NUMBER

3.3:
504aa69 Correct the synthetisized OPENSSL_VERSION_NUMBER

3.2:
d4d9859 Correct the synthetisized OPENSSL_VERSION_NUMBER

3.0:
80c4679 Correct the synthetisized OPENSSL_VERSION_NUMBER

openssl-machine pushed a commit that referenced this pull request Aug 13, 2025
The last hex digit always became 0x0L, even of OPENSSL_VERSION_PRE_RELEASE
was the empty string.

Resolves: #28227

Reviewed-by: Paul Yang <[email protected]>
Reviewed-by: Paul Dale <[email protected]>
(Merged from #28230)

(cherry picked from commit ba2c314)
@levitte levitte closed this Aug 13, 2025
@levitte levitte deleted the fix-28227 branch August 13, 2025 04:24
@t8m t8m mentioned this pull request Sep 1, 2025
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approval: ready to merge The 24 hour grace period has passed, ready to merge branch: master Applies to master branch branch: 3.0 Applies to openssl-3.0 branch branch: 3.2 Applies to openssl-3.2 (EOL) branch: 3.3 Applies to openssl-3.3 branch: 3.4 Applies to openssl-3.4 branch: 3.5 Applies to openssl-3.5 severity: fips change The pull request changes FIPS provider sources style: waived exempted from style checks tests: exempted The PR is exempt from requirements for testing triaged: bug The issue/pr is/fixes a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

OpenSSL version number always indicates pre-release

4 participants