OLS-1379: Forward user's token #2214
Conversation
|
@onmete: This pull request references OLS-1379 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@onmete: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/assign @tisnik |
| """ | ||
| user_token = "" # no-op auth yield no token |
There was a problem hiding this comment.
NO_TOKEN or something similar stored in constants perhaps?
|
|
||
| # Check if the correct user info has been returned | ||
| assert user_uid == user_id_in_request | ||
| assert username == DEFAULT_USER_NAME | ||
| assert skip_user_id_check is True | ||
| assert token == "" |
There was a problem hiding this comment.
dtto (as DEFAULT_USER_NAME) might be more readable
| @@ -163,7 +165,7 @@ def conversation_request( | |||
| def process_request( | |||
| auth: Any, llm_request: LLMRequest | |||
| ) -> tuple[ | |||
| str, str, str, list[CacheEntry], list[Attachment], bool, dict[str, float], str | |||
| str, str, str, list[CacheEntry], list[Attachment], bool, dict[str, float], str, str | |||
There was a problem hiding this comment.
hmm sooner or later it would be valuable to create a model class for this tuple
|
|
||
| # Check if the correct user info has been returned | ||
| assert user_uid == DEFAULT_USER_UID | ||
| assert username == DEFAULT_USER_NAME | ||
| assert skip_user_id_check is True | ||
| assert token == "" |
|
|
||
| # Check if the correct user info has been returned | ||
| assert user_uid == DEFAULT_USER_UID | ||
| assert username == DEFAULT_USER_NAME | ||
| assert skip_user_id_check is True | ||
| assert token == "" |
Description
Forward user's token for future use in agent/tool
Type of change