Loosen deps

[onmete]

Description

Trying to loose deps

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.06%. Comparing base (e53e0c2) to head (607795a).
Report is 116 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2154      +/-   ##
==========================================
+ Coverage   96.99%   97.06%   +0.06%     
==========================================
  Files          72       73       +1     
  Lines        2930     3064     +134     
==========================================
+ Hits         2842     2974     +132     
- Misses         88       90       +2     

see 2 files with indirect coverage changes

[onmete]

/retest

[onmete]

/assign @tisnik

[tisnik]

why is the sections in pyproject.toml moved into new places? Please keep the PR minimal.

Also don't we need to provide at least minimal major.minor versions for all packages?

Also black and mypy will be problematic if not pinned.

[onmete]

• The pyproject.toml wasn't manual job, I guess the new pdm version did the reorganization.
• minimal major.minor - then you need to periodically also increase the minimal version of all libs, no?
• black and mypy will be problematic if not pinned - can pin

[tisnik]

• The pyproject.toml wasn't manual job, I guess the new pdm version did the reorganization.

probably. Could you please minimize changes made there?
And check PDM version you use locally?

* minimal major.minor - then you need to periodically also increase the minimal version of all libs, no?

no, just we'll keep it as is

* black and mypy will be problematic if not pinned - can pin

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from tisnik. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[onmete]

@tisnik
Added minor versions.
Black and mypy pinned.
I've pinned the pdm to the previous version, but the pyproject.toml is still shuffled a bit, but I don't think it is that big of a deal. The changes are readable.

[onmete]

/test 4.17-e2e-ols-cluster

[onmete]

/test 4.17-e2e-ols-cluster

[onmete]

/test 4.17-e2e-ols-cluster

[tisnik]

can you please minimize changes made in pyproject.toml? Don't move/rename sections etc.

[tisnik]

Keep these lines there too please:

# The following section is needed only for torch[cpu] variant on Linux,
# because this variant need to be downloaded from external link, not from
# standard Python package index:
#
# [[tool.pdm.source]]
# type = "find_links"
# url = "https://download.pytorch.org/whl/cpu/torch_stable.html"
# name = "torch"

[onmete]

/test 4.17-e2e-ols-cluster

[JoaoFula]

/lgtm

[onmete]

/test 4.17-e2e-ols-cluster

[onmete]

/test 4.17-e2e-ols-cluster

[onmete]

/test 4.17-e2e-ols-cluster

[onmete]

/test 4.17-e2e-ols-cluster

[JoaoFula]

Hi @onmete , this failure seems a bit suspicious https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/test-platform-results/pr-logs/pull/openshift_lightspeed-service/2154/pull-ci-openshift-lightspeed-service-main-4.17-e2e-ols-cluster/1887513017717886976/artifacts/e2e-ols-cluster/e2e/artifacts/azure_openai/cluster/podlogs/lightspeed-app-server-65b8c56756-bv7px-lightspeed-service-api.log

Let's see this next run but if the failure remains, we might have a dependency issue happening right now.

[tisnik]

Hi @onmete , this failure seems a bit suspicious https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/test-platform-results/pr-logs/pull/openshift_lightspeed-service/2154/pull-ci-openshift-lightspeed-service-main-4.17-e2e-ols-cluster/1887513017717886976/artifacts/e2e-ols-cluster/e2e/artifacts/azure_openai/cluster/podlogs/lightspeed-app-server-65b8c56756-bv7px-lightspeed-service-api.log

Let's see this next run but if the failure remains, we might have a dependency issue happening right now.

missing deps perhaps

[tisnik]

pyaml seems to be missing, indeed

[openshift-ci]

New changes are detected. LGTM label has been removed.

[openshift-ci]

@onmete: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/4.17-e2e-ols-cluster	e63dce2	link	true	/test 4.17-e2e-ols-cluster

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.