Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-45029: dev-console cypress feature file test update #14685

Merged
merged 1 commit into from
Jan 28, 2025

Conversation

The-Anton
Copy link
Contributor

@The-Anton The-Anton commented Jan 16, 2025

@openshift-ci openshift-ci bot added component/dev-console Related to dev-console component/topology Related to topology labels Jan 16, 2025
@The-Anton The-Anton changed the title [No-Jira] : dev-console cypress feature file test case update [No-Jira] : dev-console cypress feature file test update Jan 16, 2025
@The-Anton
Copy link
Contributor Author

/retest

@The-Anton
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot
Copy link
Contributor

@The-Anton: No Jira issue is referenced in the title of this pull request.
To reference a jira issue, add 'XYZ-NNN:' to the title of this pull request and request another refresh with /jira refresh.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@The-Anton The-Anton changed the title [No-Jira] : dev-console cypress feature file test update OCPBUGS-45029 : dev-console cypress feature file test update Jan 17, 2025
@The-Anton
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot
Copy link
Contributor

@The-Anton: No Jira issue is referenced in the title of this pull request.
To reference a jira issue, add 'XYZ-NNN:' to the title of this pull request and request another refresh with /jira refresh.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@The-Anton The-Anton changed the title OCPBUGS-45029 : dev-console cypress feature file test update OCPBUGS-45029: dev-console cypress feature file test update Jan 17, 2025
@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. labels Jan 17, 2025
@openshift-ci-robot
Copy link
Contributor

@The-Anton: This pull request references Jira Issue OCPBUGS-45029, which is invalid:

  • expected the bug to target either version "4.19." or "openshift-4.19.", but it targets "4.18.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

OCPBUGS-45031, OCPBUGS-45023, OCPBUGS-45025, OCPBUGS-45030, OCPBUGS-45029, OCPBUGS-45018, OCPBUGS-45032

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Jan 17, 2025
@The-Anton
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot
Copy link
Contributor

@The-Anton: This pull request references Jira Issue OCPBUGS-45029, which is invalid:

  • expected the bug to target either version "4.19." or "openshift-4.19.", but it targets "4.18.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@The-Anton
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jan 17, 2025
@openshift-ci-robot
Copy link
Contributor

@The-Anton: This pull request references Jira Issue OCPBUGS-45029, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.19.0) matches configured target version for branch (4.19.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sanketpathak

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@The-Anton
Copy link
Contributor Author

/retest

@openshift-ci-robot
Copy link
Contributor

@The-Anton: This pull request references Jira Issue OCPBUGS-45029, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.19.0) matches configured target version for branch (4.19.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sanketpathak

In response to this:

Fix : OCPBUGS-45031, OCPBUGS-45023, OCPBUGS-45025, OCPBUGS-45030, OCPBUGS-45029, OCPBUGS-45018, OCPBUGS-45032

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@The-Anton
Copy link
Contributor Author

/retest

1 similar comment
@The-Anton
Copy link
Contributor Author

/retest

@The-Anton
Copy link
Contributor Author

/test e2e-gcp-console

And user clicks on Ok button on Export Application modal to start the export
And user clicks on Export Application option again
Then user can see "View logs" link, "Cancel Export", "Restart Export", and "Ok" button
# @regression
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mark it as broken with reason instead of commenting it out

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test is working; I have disabled it by mistake. I will enbale it again.

@@ -31,16 +31,17 @@ Feature: Install the Helm Release
Then user can see "Create Helm Chart Repository" form


@regression
@regression @broken-test
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add reason for marking it as broken

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure

Comment on lines 19 to 20
And user can see toast notification saying "<resource_type>" created successfully
Then user will be redirected to Topology page
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
And user can see toast notification saying "<resource_type>" created successfully
Then user will be redirected to Topology page
Then user can see toast notification saying "<resource_type>" created successfully
And user will be redirected to Topology page

Comment on lines 79 to 80
And user can see the toast notification containg the route value "home"
Then user will be redirected to Topology page
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
And user can see the toast notification containg the route value "home"
Then user will be redirected to Topology page
Then user can see the toast notification containg the route value "home"
And user will be redirected to Topology page

@sanketpathak
Copy link
Contributor

/lgtm
/approve

@sanketpathak
Copy link
Contributor

/label acknowledge-critical-fixes-only

@openshift-ci openshift-ci bot added the acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. label Jan 24, 2025
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 24, 2025
Copy link
Contributor

openshift-ci bot commented Jan 24, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sanketpathak, The-Anton

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 24, 2025
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD cab08c0 and 2 for PR HEAD 19f4465 in total

1 similar comment
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD cab08c0 and 2 for PR HEAD 19f4465 in total

@The-Anton
Copy link
Contributor Author

/retest

Copy link
Contributor

openshift-ci bot commented Jan 26, 2025

@The-Anton: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD cab08c0 and 2 for PR HEAD 19f4465 in total

1 similar comment
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD cab08c0 and 2 for PR HEAD 19f4465 in total

@sanketpathak
Copy link
Contributor

/retest

Copy link
Contributor

openshift-ci bot commented Jan 28, 2025

@The-Anton: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit e0e1f57 into openshift:master Jan 28, 2025
7 checks passed
@openshift-ci-robot
Copy link
Contributor

@The-Anton: Jira Issue OCPBUGS-45029: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-45029 has been moved to the MODIFIED state.

In response to this:

Fix : OCPBUGS-45031, OCPBUGS-45023, OCPBUGS-45025, OCPBUGS-45034, OCPBUGS-45030, OCPBUGS-45029, OCPBUGS-45018, OCPBUGS-45032

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: openshift-enterprise-console
This PR has been included in build openshift-enterprise-console-container-v4.19.0-202501281107.p0.ge0e1f57.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. approved Indicates a PR has been approved by an approver from all required OWNERS files. component/dev-console Related to dev-console component/topology Related to topology jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants