Skip to content

Conversation

@viv3ckj
Copy link
Contributor

@viv3ckj viv3ckj commented Jun 20, 2025

Closes #178

@viv3ckj viv3ckj requested a review from milanwiedemann June 20, 2025 13:18
Copy link
Member

@milanwiedemann milanwiedemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks :) left some comments but looks great

README.md Outdated
# Licences
As standard, research projects have a MIT license.

NHS BSA data is retrieved via their API ([code](https://github.com/opensafely/pharmacy-first/blob/1a2659a718b4139fa5863c16e11bc751e529e7d5/lib/functions/get_pf_consultation_validation_data.R#L60)) and used for comparison in our analyses ([code](https://github.com/opensafely/pharmacy-first/blob/main/lib/functions/combine_os_nhsbsa_validation_data.R)).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for finding the correct licence, I'd add some more info about what data we using and keep it a bit more simple like this?

Suggested change
NHS BSA data is retrieved via their API ([code](https://github.com/opensafely/pharmacy-first/blob/1a2659a718b4139fa5863c16e11bc751e529e7d5/lib/functions/get_pf_consultation_validation_data.R#L60)) and used for comparison in our analyses ([code](https://github.com/opensafely/pharmacy-first/blob/main/lib/functions/combine_os_nhsbsa_validation_data.R)).
NHS BSA data OF PHARMACY FIRST CONSULTATIONS ON A NATIONAL AND REGIONAL LEVEL is retrieved via their API, see ADD LINK TO WEBSITE WHERE THEY DESCRIBE API.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Milan, I've made the change now.

@viv3ckj viv3ckj merged commit 66221ac into main Jun 27, 2025
1 check passed
@viv3ckj viv3ckj deleted the viv3ckj/add-ogl-license branch June 27, 2025 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add OGL-UK-3.0 for NHS BSA to README.md

3 participants