Conversation
Checks the dist can be built and installed and the long description is rendered correctly on pypi
Not all wheels are available for Py3.9 yet, so CI stalls on installing some packages (see also docker-library/python#540)
Step names start with a capital. Clarified names to indicate what is done.
mfeurer
reviewed
Nov 2, 2020
Collaborator
mfeurer
left a comment
There was a problem hiding this comment.
This looks great, just one minor change request.
I think it's good to have every test as a separate file, it's much cleaner now like this.
mfeurer
approved these changes
Nov 2, 2020
Contributor
|
@all-contributors please add @PGijsbers for test |
Contributor
|
I've put up a pull request to add @PGijsbers! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think this covers the previous work that was done by Travis jobs:
developandmaster)I opted to split workflows where Travis branched merely on conditionals. I think this makes each individual workflow easier to understand. There is probably some improvement to be made by using predefined Github Actions, but I think this is good enough for me right now. I would rather focus on setting up Github Actions for our Windows testing.