Conversation
Codecov Report
@@ Coverage Diff @@
## develop #853 +/- ##
=========================================
- Coverage 88.49% 88.4% -0.1%
=========================================
Files 37 37
Lines 4269 4269
=========================================
- Hits 3778 3774 -4
- Misses 491 495 +4
Continue to review full report at Codecov.
|
mfeurer
left a comment
There was a problem hiding this comment.
Thanks a lot, this looks really good. However, could you please explain why you need an extra test given that the example is executed by travis-ci?
I came across the issue #805 and thought this was a good opportunity to incorporate it. Also, I came across a unit test for the SVM example. Hence, I thought this was the protocol. |
Reference Issue
Addresses #852.
What does this PR implement/fix? Explain your changes.
Removes the repeated calls to
openml.runs.get_runsand replaces it with one single API call usingopenml.evaluations.list_evaluations_setups.Also, added a unit test for this example.