-
-
Notifications
You must be signed in to change notification settings - Fork 245
Issue 540 #547
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Issue 540 #547
Changes from all commits
Commits
Show all changes
45 commits
Select commit
Hold shift + click to select a range
fda4b90
Add unit test for list of lists dataset upload
ArlindKadra 2c7fd30
Fixing xml pattern typo
ArlindKadra ed33768
Fix pep8 no newline at the end of file
ArlindKadra a4ebfa7
Remove format from definitions
ArlindKadra ebd7113
Restoring format in dataset
ArlindKadra 5d6053e
Fixing a couple of unused imports and fixings bugs with create_datase…
ArlindKadra fbc1f6b
Adapting unit tests to changes
ArlindKadra 6a3ffb8
Fixing failing unit tests
ArlindKadra 7dc9355
fixing typo
ArlindKadra 7b0fdde
Enforce pep8 style guide, fix doc tutorial trying to invoke create_da…
ArlindKadra 2d7b75c
Workaround for pep8 style guide
ArlindKadra 2919dd6
fix long time typo
ArlindKadra 1c4faff
update pep8 failing statement and bug fix for dataset upload tutorial
ArlindKadra 3602739
fixed problem with arff file
ArlindKadra 46cf1fa
Fix pep8 line too long
ArlindKadra 693c368
Extending the unit test for dataset upload, changing upload tutorial
ArlindKadra e29cf4d
Workaround for the dataset upload unit test
ArlindKadra f0d8200
Adding example with weather dataset into the dataset upload tutorial
ArlindKadra be7791f
Fixing builds failure
ArlindKadra 5011216
Adding support for sparse datasets, implementing corresponding unit t…
ArlindKadra 005649a
fix bug
ArlindKadra b4103df
More unit tests and bug fix
ArlindKadra 2e898ee
Fixing bugs
ArlindKadra 43c6530
Fix bug and pep8 errors
ArlindKadra f45adbf
Enforcing pep8 and fixing changing the name of attribute format as it…
ArlindKadra cfd5767
Implementing change in a better way
ArlindKadra 82c7173
Fixing bugs introduced by changing the format in the constructor
ArlindKadra 61cd547
Another try to tackle the bugs
ArlindKadra 4ec6b23
Small refactor
ArlindKadra 45321d2
Fixing pep8 error
ArlindKadra 654cbd0
Fix python2.7 bug
ArlindKadra 714619f
making changes in accordance with Guillaume's suggestions
ArlindKadra e858689
Adding unit tests, small refactoring
ArlindKadra e711267
Enforcing pep8 style
ArlindKadra a3dbb9a
Following Matthias's suggestions
ArlindKadra 4ae71be
Fixing bug introduced by variable name change
ArlindKadra f922654
Changing the breast_cancer dataset to diabetes, fixing typo with weat…
ArlindKadra e84c42d
Further changes
ArlindKadra 0f653a3
Merge branch 'develop' into fix540
ArlindKadra 1d7f8eb
Adding more changes
ArlindKadra 82b4758
Fixing bug
ArlindKadra fc53ef6
Merge branch 'fix540' of https://github.com/openml/openml-python into…
ArlindKadra 0edea31
Pep8 enforce
ArlindKadra 751f8c9
few changes
ArlindKadra 0c66cfc
Fixing typo in dataset name attributes
ArlindKadra File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -25,6 +25,11 @@ env: | |
| - DISTRIB="conda" PYTHON_VERSION="3.6" SKLEARN_VERSION="0.19.2" | ||
| - DISTRIB="conda" PYTHON_VERSION="3.6" SKLEARN_VERSION="0.18.2" | ||
|
|
||
| # Travis issue | ||
| # https://github.com/travis-ci/travis-ci/issues/8920 | ||
| before_install: | ||
| - python -c "import fcntl; fcntl.fcntl(1, fcntl.F_SETFL, 0)" | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What is it useful for?
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. A workaround, the travis-ci builds started failing not long ago. |
||
|
|
||
| install: source ci_scripts/install.sh | ||
| script: bash ci_scripts/test.sh | ||
| after_success: source ci_scripts/success.sh && source ci_scripts/create_doc.sh $TRAVIS_BRANCH "doc_result" | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,8 +1,21 @@ | ||
| from .functions import (list_datasets, check_datasets_active, | ||
| get_datasets, get_dataset, status_update) | ||
| from .functions import ( | ||
| check_datasets_active, | ||
| create_dataset, | ||
| get_dataset, | ||
| get_datasets, | ||
| list_datasets, | ||
| status_update, | ||
| ) | ||
| from .dataset import OpenMLDataset | ||
| from .data_feature import OpenMLDataFeature | ||
|
|
||
| __all__ = ['check_datasets_active', 'get_dataset', 'get_datasets', | ||
| 'OpenMLDataset', 'OpenMLDataFeature', 'list_datasets', | ||
| 'status_update'] | ||
| __all__ = [ | ||
| 'check_datasets_active', | ||
| 'create_dataset', | ||
| 'get_dataset', | ||
| 'get_datasets', | ||
| 'list_datasets', | ||
| 'OpenMLDataset', | ||
| 'OpenMLDataFeature', | ||
| 'status_update', | ||
| ] |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please add a comment here on why this is necessary as in #560?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, I missed doing that.