Conversation
janvanrijn
reviewed
Apr 4, 2018
Member
janvanrijn
left a comment
There was a problem hiding this comment.
Up to discretion of @mfeurer
- we don't need to create cache directory structure already in set_cache_dir() fn
- for this reason the config object doesn't need getters and setters
I will approve once the unit tests succeed
Collaborator
Author
|
This now also partially solves #396. However, not as nicely as expected. |
janvanrijn
approved these changes
Apr 5, 2018
Member
janvanrijn
left a comment
There was a problem hiding this comment.
Approved. But Please address my comments :)
| def test_get_setup(self): | ||
| # no setups in default test server | ||
| openml.config.server = 'https://www.openml.org/api/v1/xml/' | ||
| openml.config.set_server_url('https://www.openml.org/api/v1/xml/') |
openml/testing.py
Outdated
| def tearDown(self): | ||
| os.chdir(self.cwd) | ||
| shutil.rmtree(self.workdir) | ||
| for i in range(10): |
Member
|
@mfeurer @janvanrijn If you like the current implementation, you can merge the pull the request. Build is passing. |
Collaborator
Author
|
Thanks for the fix @ArlindKadra. Could you please describe which change was actually necessary to fix it? Also, could you please explain the reasoning for changing the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.