Conversation
Codecov Report
@@ Coverage Diff @@
## develop #405 +/- ##
===========================================
+ Coverage 89.02% 89.09% +0.07%
===========================================
Files 32 32
Lines 2660 2668 +8
===========================================
+ Hits 2368 2377 +9
+ Misses 292 291 -1
Continue to review full report at Codecov.
|
mfeurer
requested changes
Feb 22, 2018
Collaborator
mfeurer
left a comment
There was a problem hiding this comment.
Looks great, only a minor remark.
| if len(datasets) > 0: | ||
| raise ValueError('UnitTest Outdated, tag was already used (please remove)') | ||
|
|
||
| self.assertIsInstance(datasets, dict) |
Collaborator
There was a problem hiding this comment.
You should also check that the dictionary is actually empty.
| if len(evaluations) > 0: | ||
| raise ValueError('UnitTest Outdated, got somehow results') | ||
|
|
||
| self.assertIsInstance(evaluations, dict) No newline at end of file |
| if len(runs) > 0: | ||
| raise ValueError('UnitTest Outdated, got somehow results') | ||
|
|
||
| self.assertIsInstance(runs, dict) |
| if len(setups) > 0: | ||
| raise ValueError('UnitTest Outdated, got somehow results') | ||
|
|
||
| self.assertIsInstance(setups, dict) |
| if len(tasks) > 0: | ||
| raise ValueError('UnitTest Outdated, got somehow results (tag is used, please adapt)') | ||
|
|
||
| self.assertIsInstance(tasks, dict) |
mfeurer
approved these changes
Feb 22, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensures that listing fn consistently returns a dict