[ENH] Replace asserts with proper if else Exception handling

[Omswastik-11]

Fixes #1581

[Omswastik-11]

Hi @fkiraly !! I would like to know you suggestion on this .

In openml\runs\run.py the _generate_arff_dict function is causing the above issue . so I created a new function _get_arff_attributes_for_task to reduce complexity is it ok ? or should I think of a alternate solution ?

[fkiraly]

Yes, looks reasonable for me for a first go, to isolate the if/else in a function.

More generally, from an architecture standpoint however, whenever I see a long list of if/elses on the argument class type, I think it is too high coupling and it should be either a method of the (task/argument) class or a visitor pattern.

Why: imagine you want to add a new task. Now you have to add another elif in all of these functions. This is absolutely not extensible.

This should be refactored - I would say, in another PR, after opening an issue with a plan - so the task itself, or a visitor, manages whatever is in the if/else.

[codecov-commenter]

Codecov Report

❌ Patch coverage is 4.65116% with 41 lines in your changes missing coverage. Please review.
✅ Project coverage is 52.72%. Comparing base (7feb2a3) to head (b8a7992).

Files with missing lines	Patch %	Lines
openml/runs/run.py	4.34%	22 Missing ⚠️
openml/runs/functions.py	7.14%	13 Missing ⚠️
openml/runs/trace.py	0.00%	6 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1589      +/-   ##
==========================================
- Coverage   52.82%   52.72%   -0.10%     
==========================================
  Files          37       37              
  Lines        4371     4381      +10     
==========================================
+ Hits         2309     2310       +1     
- Misses       2062     2071       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[geetu040]

Good, just ran the tests in tests/test_runs/ to be sure of the refactor, and it's green.
Ready to be merged!

[Copilot]

Pull request overview

This PR replaces assert-based validation in the openml.runs module with explicit exceptions, improving reliability (asserts can be stripped with Python -O) and providing clearer failure modes. It also refactors ARFF attribute construction into a dedicated helper to reduce duplication.

Changes:

• Replaced multiple assert ... is not None validations with ValueError/TypeError raises across runs-related code paths.
• Added OpenMLRun._get_arff_attributes_for_task() and used it from _generate_arff_dict() to centralize ARFF attribute generation.
• Tightened runtime type checks for inputs derived from task data (y type in parallel helper).

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File	Description
openml/runs/trace.py	Replaces asserts with explicit exceptions when parameters are unexpectedly missing.
openml/runs/run.py	Adds a helper for task-dependent ARFF attributes; replaces flow-id assertion with explicit error.
openml/runs/functions.py	Replaces several asserts with explicit exceptions in run/model initialization and run-list parsing.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.