Conversation
mfeurer
left a comment
There was a problem hiding this comment.
I just skimmed this and left a few comments. I think this is a good idea. Do you plan to add a build action to github actions?
|
I added a Github workflow that automatically builds and pushes a docker image on a push to |
mfeurer
left a comment
There was a problem hiding this comment.
This looks good, interestingly, the workflow is a bit different to the one we use in Auto-sklearn (https://github.com/automl/auto-sklearn/blob/master/.github/workflows/docker-publish.yml). I think we can copy over one or two things, such as running the unit tests and correctly setting the tag, but besides that it looks good to me.
Co-authored-by: Matthias Feurer <feurerm@informatik.uni-freiburg.de>
…nment (openml#1075) * Initial structure * Add doc and test functionality for mounted repo * Add branch support and safeguards * Update docker usage and name, add structure * Improved formatting * Add reference to docker image from main docs * Add Workflow to build and push docker image * Use environment variable directly * Try other formatting for SHA tag * Try format as string * Only push latest * Explicitly make context relative * Checkout repository * Install wheel and setuptools before other packages * Rename master to main * Add information about Docker PR * Make 'note' italtics instead of content Co-authored-by: Matthias Feurer <feurerm@informatik.uni-freiburg.de> Co-authored-by: Matthias Feurer <feurerm@informatik.uni-freiburg.de>
Due to my recent difficulties building the docs from my Windows machine (still not sure why it broke), I decided to make a docker image that can be used to:
develop.Please refer to the included documentation for more information.
I think it'll be useful for anyone who wishes to execute these tasks in an isolated environment, though the primary audience is probably Windows users.
Looking for feedback, but I will still add: