Conversation
PGijsbers
reviewed
Mar 26, 2021
Collaborator
Author
|
I'm surprised about the loky issue, I though we had fixed that in f94672e#diff-062b8d0134bb5a02a7a6209393cf252284a8e0dd29483a36595cae93a981f725 by reordering the way the config is loaded... |
PGijsbers
approved these changes
Mar 26, 2021
Collaborator
PGijsbers
left a comment
There was a problem hiding this comment.
Approving the PR since the changes make sense. The failing unit tests seem unrelated.
PGijsbers
pushed a commit
to Mirkazemi/openml-python
that referenced
this pull request
Feb 23, 2023
* skip two unit tests on Windows * make tests less strict for Windows
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.