Skip to content

fix: bound publishing requests and narrow-screen invitation - #318

Merged
steipete merged 4 commits into
openclaw:mainfrom
SebTardif:fix/publish-fetch-timeouts
Nov 21, 2026
Merged

steipete merged 4 commits into
openclaw:mainfrom
SebTardif:fix/publish-fetch-timeouts

Conversation

@SebTardif

@SebTardif SebTardif commented Nov 20, 2026 •

Copy link
Copy Markdown
Contributor

Stalled network requests prevented the publishing smoke retry loop and R2 credential fallback from running. Bound both llms-full fetches, both token-verification curl calls, and the temporary credential request to 30 seconds. This makes existing retry/fallback handling reachable without changing the publishing flow.

The community invitation also uses the layout viewport for its mobile width and disables its slide transition under reduced motion. The settled appearance is unchanged; on the same reduced-motion WebKit fixture, the computed transition duration changes from 0.2s to 0s.

Validation:

  • A real nonresponding local HTTP server leaves all three workflow fetch expressions pending on the old code and produces TimeoutError with the patch. The committed regression executes those actual expressions, uses synthetic credentials, and never calls a live provider.
  • All 312 renderer/Worker tests pass on an isolated Linux worker.
  • The 30-page preview and all 20 community-invitation Chromium/WebKit theme/viewport checks pass.
  • Codex autoreview reports no actionable P0–P2 findings.
  • Full shell-build, smoke, visual, and CodeQL CI must pass at the exact head before merge.

Before and after, captured from the synthetic fixture in WebKit at 320 × 568 with reduced motion:

Before

After

No release, version bump, live credential use, or manual deployment.

@SebTardif
SebTardif requested a review from a team as a code owner November 20, 2026 13:57
SebTardif and others added 4 commits November 20, 2026 17:55
A hung fetch in the llms-full smoke loop never reaches its 10 minute
deadline, and a hung curl or mint fetch never reaches the stored
credential fallback. Bound both the same way docs live smoke already
does.

Signed-off-by: Sebastien Tardif <sebtardif@ncf.ca>
The validate job was cancelled during Playwright install at the 30 minute cap. Recent docs-code-ci runs on this repo finish in about 7 to 13 minutes.

Signed-off-by: Sebastien Tardif <sebtardif@ncf.ca>
A classic scrollbar is part of 100vw, so the docked card can extend
past the layout viewport. Size that card to the viewport, and skip its
drawer slide when motion is reduced.

Signed-off-by: Sebastien Tardif <sebtardif@ncf.ca>
@steipete
steipete force-pushed the fix/publish-fetch-timeouts branch from 36969ed to b3b9892 Compare November 21, 2026 01:56
@steipete steipete changed the title fix: abort stalled llms-full and R2 credential calls fix: bound publishing requests and narrow-screen invitation Nov 21, 2026
@steipete
steipete merged commit 4c3af53 into openclaw:main Nov 21, 2026
5 checks passed
@steipete

Copy link
Copy Markdown
Contributor

Merged as 4c3af53, preserving Sebastien's contributor credit. The new workflow-expression regression fails against the previous main and passes after the fix with a real nonresponding local HTTP server and synthetic credentials. All 312 renderer/Worker tests, the bounded preview, and all 20 Chromium/WebKit invitation combinations passed. Inspected before/after images are in the PR; Codex autoreview had no actionable P0–P2 findings.

Exact-head CI: https://github.com/openclaw/docs/actions/runs/44853082855

Post-merge main build/upload and live smoke are green: https://github.com/openclaw/docs/actions/runs/44854130628 and https://github.com/openclaw/docs/actions/runs/44854709735. No live credential test, manual deployment, or release was performed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants