Skip to content

fix: harden Claude ACP session creation stalls#71

Merged
vincentkoc merged 2 commits intomainfrom
vincentkoc-code/issue-29-claude-acp-disconnect
Mar 9, 2026
Merged

fix: harden Claude ACP session creation stalls#71
vincentkoc merged 2 commits intomainfrom
vincentkoc-code/issue-29-claude-acp-disconnect

Conversation

@vincentkoc
Copy link
Member

Summary

  • add a Claude-specific ACP session creation timeout so acpx does not hang forever on stalled session/new calls
  • surface an actionable CLAUDE_ACP_SESSION_CREATE_TIMEOUT error with non-interactive guidance for harness users
  • add mock-agent and integration coverage for a hung Claude ACP adapter

Validation

  • pnpm run check
  • live smoke: acpx claude sessions new --name claude-live-smoke completed on macOS arm64, but took ~46s, so the built-in guard is set to 60s

Fixes: #29

@vincentkoc vincentkoc self-assigned this Mar 9, 2026
@vincentkoc vincentkoc marked this pull request as ready for review March 9, 2026 18:42
@vincentkoc vincentkoc merged commit 54cec19 into main Mar 9, 2026
6 of 7 checks passed
@vincentkoc vincentkoc deleted the vincentkoc-code/issue-29-claude-acp-disconnect branch March 9, 2026 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Claude ACP agent fails: all sessions end with 0 turns, agent disconnects after ~3s

1 participant