Repository navigation
revert: restore unpublished v4 source state - #372
Conversation
This reverts commit 990a6aa.
|
🦞👀 Pull request received. I will update this pull request when review starts. |
|
Codex review: needs maintainer review before merge. Reviewed August 10, 2026, 8:38 AM ET / 12:38 UTC. ClawSweeper reviewWhat this changesThe PR changes the two 4.0.0 changelog headings, README wording, and release notes back from published-release text to the unpublished candidate state. Regression provenancePossible regression — suspected (reviewed change). No predecessor PR is attributed. Merge readinessKeep open. This focused collaborator PR exactly restores the documented pre-publication state after current main marked 4.0.0 as released despite no local tag containing that publication commit and the supplied release evidence showing v3.10.0 remains latest. Priority: P2 Review scores
Verification
How this fits togetherPeekaboo’s changelogs, README, and release notes communicate release state to users and release operators. The release-preflight tooling consumes the changelog state before publication, while published artifacts add the tag, GitHub release, npm package, and appcast entry. flowchart LR
A[Candidate source text] --> B[Changelogs and README]
B --> C[Release preflight]
C --> D[Publication workflow]
D --> E[Tag npm appcast and GitHub release]
E --> F[Published release state]
Before merge
Agent review detailsSecurityNone. Review metrics
Technical reviewBest possible solution: Merge the exact reversion so source documentation remains in the candidate state until the complete public 4.0.0 publication workflow has run. Do we have a high-confidence way to reproduce the issue? Not applicable: this is a source and release-metadata correction rather than a runtime defect. Current history and the release-preflight contract establish the relevant verification path. Is this the best way to solve the issue? Yes. Given the supplied absence of public 4.0.0 artifacts, an exact inverse of the publication-text commit is the narrowest way to restore the repository’s documented candidate state. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against 990a6aa0e4f2. LabelsLabel changes:
Label justifications:
EvidenceWhat I checked:
Likely related people:
Rating scale
Overall follows the weaker of proof and patch quality. Workflow
|
|
Heads up before this merges: a release run is in flight right now and is past the point your evidence was gathered. Your premise was correct when you wrote it — every earlier run failed, so
All five are fixed. The current run has produced a signed universal CLI, passed CLI notarization, built and signed the Mac app, and is now waiting on DMG notarization, with the GitHub Release and npm publish still to come. So the choice is timing, not correctness. If the run finishes, merging this would leave a published 4.0.0 marked |
@steipete/peekaboo@4.0.0 is live on npm, so the source now claims a release that exists. Restores the dated 4.0.0 changelog headings and shipped-tense copy reverted by #372, and adds the signed 4.0.0 Sparkle appcast item.
|
Outcome, as promised: the release completed. Proof:
Your revert was right for the window it covered, and it cost nothing — the artifacts were already built and notarized, so only npm publish and undrafting remained. The last two blockers after your evidence were the npm OTP requirement in a non-interactive shell, and this Mac having no One thing worth fixing separately: |
Why
Commit
990a6aa0changed source text from release-candidate state to published state, but no Peekaboo 4 publication occurred. The source therefore claimed a release that does not exist.Live evidence as of 2026-08-10:
git ls-remotereturns no matching tag.latestremains 3.10.0.Change
Exactly revert
990a6aa0so the source returns to the #371 state:4.0.0 - Unreleasedrelease/release-notes.md: last actually published release, 3.10.0Version metadata remains 4.0.0. No appcast, tag, GitHub Release, npm package, notarization, or credential state is touched.
Proof
102be49f(fix(release): keep v4 source claims honest #371)pnpm run test:release-preflight— 7/7pnpm run prepare-release -- --dry-run --bin Apps/CLI/.build/debug/peekaboopnpm run lint:docspnpm run docs:sitepnpm run test:safe— 759 Core CLI tests and 72 runtime tests